unify no service audio code paths #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulJKim
reviewed
Nov 12, 2024
| %Content.Message.Headways.Bottom{range: {8, 10}} | ||
| ) | ||
| end | ||
| test "from_messags/2" do |
| {:ok, destination_text} = PaEss.Utilities.destination_to_ad_hoc_string(destination) | ||
| "No #{destination_text} service.#{shuttle}" | ||
|
|
||
| use_routes? -> |
There was a problem hiding this comment.
should this clause not come first in the cond block? Based on the definition for from_messages/2 above for this special case, it looks like destination could still be truthy
There was a problem hiding this comment.
Currently it doesn't matter, because we always generate a destination-less Message.Alert.NoService for this case. I've got a followup PR that changes that code path and this logic, but I went ahead and swapped it anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This refactors the
ClosureandNoServiceToDestinationaudio modules into a singleNoServiceaudio. These code paths were closely related to each other, and unifying them simplifies the calling code. Test coverage is maintained by the suite of higher level cases inrealtime_test.exs. Also includes a few minor simplifications to the headway and first-train audio constructors.