Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text for Union Square Shuttles to replace 86 with 109 #857

Merged
merged 3 commits into from
Dec 15, 2024

Conversation

robbie-sundstrom
Copy link
Contributor

Summary of changes

Asana Ticket: Update text for union square shuttles

Route 86 will no longer service Union Square after the Bus Network Redesign, and be replaced at Union Square by Route 109.

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • If signs.json was changed, there is a follow-up PR to signs_ui to update its dependency on this project
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes (compare on Splunk: staging vs. prod)

@robbie-sundstrom robbie-sundstrom requested a review from a team as a code owner December 13, 2024 14:26
Copy link
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR! 🎊

lib/content/audio/no_service.ex Outdated Show resolved Hide resolved
Copy link
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1️⃣0️⃣9️⃣✅

Brett may have gone over this with you already, but we generally avoid merge commits. So either "Squash and merge" (probably most convenient for this specific change), or rewrite commits to how you want them to look on main and then "Rebase and merge".

@panentheos
Copy link
Collaborator

Looks great! Just calling out that we're going to hold off on merging/deploying this, so we can time it for when the new route takes effect.

@robbie-sundstrom robbie-sundstrom merged commit 6ba61c9 into main Dec 15, 2024
2 checks passed
@robbie-sundstrom robbie-sundstrom deleted the robbie/update-union-sq-shuttle-text branch December 15, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants