Add new bus route for BNR #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalcora
reviewed
Dec 13, 2024
| @@ -579,7 +580,8 @@ defmodule PaEss.Utilities do | |||
| {"Gallivan Blvd", "881"}, | |||
| {"Brookline Ave", "885"}, | |||
| {"Brookline Village", "886"}, | |||
| {"Cobbs Corner Canton", "887"} | |||
| {"Cobbs Corner Canton", "887"}, | |||
| {"Linden Sq", "889"} | |||
There was a problem hiding this comment.
Should this be the original headsign rather than the shortened one, i.e. "Linden Square"? The one above, "Cobbs Corner Canton", uses the full headsign.
There was a problem hiding this comment.
The caller that references this list uses String.starts_with?/2 https://github.com/mbta/realtime_signs/blob/main/lib/pa_ess/utilities.ex#L678 so we don't need to use the original headsign. I decided to use Linden Sq to be a little more flexible in case the headsign ever happens to change for some reason and come in as the abbreviated version.
|
Requesting review from @panentheos just to double-check everything is correct here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: [add-on] signs config updates for BNR
Adds route 109 to the harvard upper busway as well as new audio for this route and its headsign.