Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix harvard upper busway stop ids #859

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

PaulJKim
Copy link
Collaborator

Summary of changes

Asana Ticket: Fix up Harvard upper busway stops (third time's the charm!)

Fix stop ids after BNR initial launch

@PaulJKim PaulJKim requested a review from a team as a code owner December 16, 2024 14:55
Copy link
Contributor

@robbie-sundstrom robbie-sundstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Next step would be a follow-up PR to signs-ui I believe?

@PaulJKim
Copy link
Collaborator Author

@robbie-sundstrom nope no need for a signs UI pr! Once this goes out, we'll start sending the missing predictions to the harvard busway sign right away. Signs UI just acts as a viewer for us to visualize what we're sending out to signs, along with some controls that OIOs use to set signs into different modes and configure headway values etc.

@PaulJKim PaulJKim merged commit 18d7db9 into main Dec 16, 2024
2 checks passed
@PaulJKim PaulJKim deleted the pk/fix-harvard-busway-screens branch December 16, 2024 15:11
@digitalcora
Copy link
Contributor

@PaulJKim It is part of the PR checklist that changes to signs.json here should also be propagated to SignsUI. Maybe there are some categories of change to signs.json that don't have any effect on the way SignsUI uses the file, but I'm not sure off-hand if this is one of those. Do you have a better handle on this?

@PaulJKim
Copy link
Collaborator Author

Ah, you're right - we should update the dependency in Signs UI so that prediction suppression works for the new stop_ids. Sorry @robbie-sundstrom, you were correct!

@PaulJKim
Copy link
Collaborator Author

Well actually, we don't include the busway signs in the stop_id to sign mapping so we don't need to update the RTS dependency here since it won't affect signs UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants