extract prediction helpers #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulJKim
reviewed
Jan 8, 2025
| @spec prediction_approaching?(Predictions.Prediction.t(), boolean()) :: boolean() | ||
| def prediction_approaching?(prediction, terminal?) do | ||
| !terminal? and !prediction.stopped_at_predicted_stop? and | ||
| prediction_seconds(prediction, terminal?) in 31..60 |
There was a problem hiding this comment.
Technically terminal? can only ever be false when predictions_seconds/2 is called here. Should we just explicitly pass false as the second param?
There was a problem hiding this comment.
I kind of went back and forth on that. Technically we could just hardcode it, but it creates a little bit of unnecessary coupling in the logic, so I'm inclined to leave it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This extracts several helpers related to predictions, as a part of the larger message refactoring effort. Notes:
Aside from these few cases, the overall system behavior should be unchanged.