Bottom action bar #242
Merged
Bottom action bar #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulJKim
requested review from
a team and
hannahpurcell
and removed request for
a team
PaulJKim
force-pushed
the
pk/bottom-action-bar
branch
from
6cd81f7 to
3498d31
Compare
hannahpurcell
approved these changes
Dec 20, 2023
|
@PaulJKim Just FYI while you are out, I am going to resolve the merge conflicts and merge this into the feature branch. I know you were waiting on some other PRs to be merged before doing so, but I believe we are caught up on those. |
cmaddox5
changed the base branch from
cm/gl-eink-config-page
to
permanent-configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana task: [Perm config] Create Bottom Action Bar Component + paging logic
Description
Branched off of #235
This PR adds a reusable bottom action bar that takes in button labels and actions as props.
State should be preserved as a user pages through the configuration steps, and while there is currently no state to be saved, I think we should be able to initialize/maintain state at the top level component for a given screen type (
GlEinkConfigPagein this case) and pass that down to any future child components that will be used for the actual configurable aspects.