Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore local dependencies in dependabot. #303

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

cmaddox5
Copy link
Contributor

Asana task: ad-hoc

Dependabot isn't successfully retrieving updates because it doesn't know where to look for Phoenix upgrades. These are local dependencies anyway so can just ignore them.

@cmaddox5 cmaddox5 requested review from a team and jzimbel-mbta and removed request for a team April 17, 2024 17:46
Copy link
Member

@jzimbel-mbta jzimbel-mbta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I'm a little confused: How are phoenix and phoenix_html local dependencies? They're definitely used in deployment environments.

And is there any reason why it has trouble finding new versions of those two packages? Seems like it doesn't have trouble with other elixir packages.

@cmaddox5
Copy link
Contributor Author

How are phoenix and phoenix_html local dependencies?

@jzimbel-mbta Maybe local dependency isn't the right phrase to use. Phoenix is very much an external dependency we manage in mix.exs. npm is just using that same dependency. So we only have to keep the elixir dependency up to date instead of maintaining an npm package AND an elixir package. You can find that here.

The problem is that Dependabot looks at npm packages and mix deps separately. That means that the Dependabot npm check does not know how to find something in deps because it does not run mix deps.get before doing it's check. Since we are only maintaining a single phoenix dependency, we can skip checking it in npm and just let the mix check keep it up to date.

@cmaddox5 cmaddox5 merged commit c6b7009 into main Apr 22, 2024
4 checks passed
@cmaddox5 cmaddox5 deleted the cm/dependabot-ignore-phoenix-npm branch April 22, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants