feat: Elevator Screens #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalcora
reviewed
Oct 22, 2024
cmaddox5
force-pushed
the
cm/support-elevator-screens
branch
from
ef230bd to
dd5effe
Compare
digitalcora
approved these changes
Oct 25, 2024
| @@ -15,20 +15,22 @@ import ScreenDetail from "Components/ScreenDetail"; | |||
| import { sortScreens } from "../../util"; | |||
| import { useUpdateAnimation } from "Hooks/useUpdateAnimation"; | |||
| import classNames from "classnames"; | |||
| import _ from "lodash"; | |||
There was a problem hiding this comment.
I thought we were using lodash/fp?
There was a problem hiding this comment.
Ahh yes thank you. (Although I dislike how bad it is at inferring types 😅)
There was a problem hiding this comment.
I agree this is a notable downside of FP and maybe something we should have considered (if we'd had a better sense for it at the time) in our conversations about which "utility library" to use. I tend to avoid Lodash entirely and use vanilla JS where feasible, since built-in classes and functions have generally excellent types (except for you, JSON.parse, you're not invited to the party).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can make elevator screens, we need to make them work in Screenplay. This involves a few things:
stop_idinBuilder. Did this with a/facilitieslookupiframes display correctlyDeploying this to dev-green so it can be seen in a deployed environment.