refactor: move detour_status definition into Db.Detour

mbta · Jan 31, 2025 · 45462f9 · 45462f9
1 parent 3304ae5
commit 45462f9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/skate/detours/db/detour.ex b/lib/skate/detours/db/detour.ex
@@ -8,6 +8,8 @@ defmodule Skate.Detours.Db.Detour do
 
   alias Skate.Settings.Db.User
 
+  @type detour_status :: :active | :draft | :past
+
   typed_schema "detours" do
     field :state, :map
     belongs_to :author, User
@@ -20,7 +22,7 @@ defmodule Skate.Detours.Db.Detour do
     ## Detour virtual fields
     # -------------------------------------------------------
     field(:status, Ecto.Enum, values: [:draft, :active, :past], virtual: true) ::
-      simple_status() | nil
+      detour_status() | nil
 
     # Route properties
     field :route_id, :string, virtual: true

diff --git a/lib/skate/detours/detours.ex b/lib/skate/detours/detours.ex
@@ -122,7 +122,7 @@ defmodule Skate.Detours.Detours do
     nil
   end
 
-  @type detour_type :: :active | :draft | :past
+  @type detour_type :: Skate.Detours.Db.Detour.detour_status()
 
   @doc """
   Takes a `Skate.Detours.Db.Detour` struct and a `Skate.Settings.Db.User` id
-Original file line number
+Diff line change
@@ Expand Up / @@ -122,7 +122,7 @@ defmodule Skate.Detours.Detours do @@
         nil
       end
-      @type detour_type :: :active | :draft | :past
+      @type detour_type :: Skate.Detours.Db.Detour.detour_status()
       @doc """
       Takes a `Skate.Detours.Db.Detour` struct and a `Skate.Settings.Db.User` id
@@ Expand Down @@