Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Cerebro Documentation #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

alvynw
Copy link

@alvynw alvynw commented Jun 29, 2021

Directions rely on pull requests for forked copy of SCALE-MAMBA and emp-agmpc

Cerebro has a few core dependencies that need to be setup before it can be used.
We provide a Dockerfile that installs all the dependencies required by Cerebro. Running the Dockerfile will build SCALE-MAMBA and EMP-AGMPC.
* Create the Dockerfile and requirements.txt.
* Dockerfile
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of putting the Dockerfile in the documentation, you can create the file and commit it to the repository. See an example here: https://github.com/opaque-systems/opaque/blob/master/docker/Dockerfile.

@@ -2,69 +2,104 @@
Cerebro Setup
*************************

Cerebro has a few core dependencies that need to be setup before it can be used.
We provide a Dockerfile that installs all the dependencies required by Cerebro. Running the Dockerfile will build SCALE-MAMBA and EMP-AGMPC.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can simply say "We provide a Dockerfile that installs Cerebro as well as its dependencies."

Comment on lines 10 to 20
The documentation fully detailing SCALE-MAMBA can be obtained by running ``make doc`` in the SCALE-MAMBA repository.

The following is copied from SCALE-MAMBA's current setup documentation.

Prerequisite Libraries:
*************************
* gcc/g++, tested with version 7.2.1
* MPIR (compiled with the -cxx flag)
* python 2.7.5 (ideally with gmpy2 installed)
* OpenSSL (tested with version 1.1.0)
* Crypto ++ (tested with version 7.0)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these should be commented out? Docker is one way to test out Cerebro, but we need to still provide an installation guide for people who want to install Cerebro from scratch.

* Crypto ++ (tested with version 7.0)



Setup Steps for SCALE-MAMBA
*****************************
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these setup instructions, it would be good to put the instructions in code blocks, instead of in text. This way, a user can just copy and paste the commands into shell and run them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want text/explanations at all? I can remove the text section if you don't want it. I will add a section that has purely shell commands which will set everything up if copy pasted into the shell. Some commands might be a bit cryptic though.



EMP-AGMPC
################
Prerequisite Libraries:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably be kept as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants