Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Zygote v0.7 #188

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Allow Zygote v0.7 #188

merged 2 commits into from
Jan 23, 2025

Conversation

mcabbott
Copy link
Owner

@mcabbott mcabbott commented Jan 23, 2025

Aims to solve errors like this, because the new Zygote allows thunks:

ERROR: MethodError: no method matching (::var"#170#∇ℳ𝒶𝓀ℯ#46"{})(::ChainRulesCore.Thunk{…}, ::Array{…}, ::Array{…}, ::Array{…})
The function `#170#∇ℳ𝒶𝓀ℯ` exists, but no method is defined for this combination of argument types.

Closest candidates are:
  (::var"#170#∇ℳ𝒶𝓀ℯ#46")(::AbstractArray{𝒯}, ::Any, ::Any, ::Any) where 𝒯
   @ Main ~/.julia/packages/Tullio/vChiX/src/macro.jl:1295

Stacktrace:
  [1] (::TullioChainRulesCoreExt.var"#tullio_back#2"{})(Δ::ChainRulesCore.Thunk{…})
    @ TullioChainRulesCoreExt ~/.julia/packages/Tullio/vChiX/ext/TullioChainRulesCoreExt.jl:9
  [2] (::Zygote.ZBack{TullioChainRulesCoreExt.var"#tullio_back#2"{…}})(dy::ChainRulesCore.Thunk{Zygote.var"#167#168"{…}})
    @ Zygote ~/.julia/packages/Zygote/ZtfX6/src/compiler/chainrules.jl:221
...

Tests of this package are a bit of a disaster but I don't have time to dig into them.

@mcabbott mcabbott merged commit 52a1bd9 into master Jan 23, 2025
6 of 16 checks passed
@mcabbott mcabbott deleted the mcabbott-patch-1 branch January 23, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant