Move almost all view functions on best::vec
and best::strbuf
behind operator->
#25
+319
−482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces
best::arrow<T>
, a helper for returning anything out of anoperator->
. The doc comment on the type explains why it exists and what C++ semantics it abuses.best::vec
andbest::strbuf
now haveoperator->
s that effectively returnbest::span
andbest::str
, respectively. This allows the removal of a ton of duplicated functions, and means that the owned types can't "lag" behind the unowned types! This also means that e.g.best::box<T[]>
does not need to duplicate all of the functions frombest::span
, like tobest::vec
used to.