Skip to content

Commit

Permalink
remove TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mdb committed Nov 17, 2022
1 parent 067fca1 commit 9847dba
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
3 changes: 0 additions & 3 deletions internal/dispatch/repository_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,14 @@ func TestRepositoryDispatchRun(t *testing.T) {
q.Set("per_page", "100")
q.Set("page", "1")

// TODO: is this correct? is it the correct response?
reg.Register(
httpmock.QueryMatcher("GET", fmt.Sprintf("repos/%s/actions/workflows", repo), q),
httpmock.StringResponse(fmt.Sprintf(getWorkflowRunsResponse, event, repo)))

// TODO: is this correct? is it the correct response?
reg.Register(
httpmock.REST("GET", fmt.Sprintf("repos/%s/actions/workflows/456", repo)),
httpmock.StringResponse(getWorkflowResponse))

// TODO: is this correct? is it the correct response?
reg.Register(
httpmock.REST("GET", fmt.Sprintf("repos/%s/actions/workflows/456", repo)),
httpmock.StringResponse(getWorkflowResponse))
Expand Down
4 changes: 0 additions & 4 deletions internal/dispatch/workflow_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,10 @@ func TestWorkflowDispatchRun(t *testing.T) {
q.Set("per_page", "100")
q.Set("page", "1")

// TODO: is this correct? is it the correct response?
reg.Register(
httpmock.QueryMatcher("GET", fmt.Sprintf("repos/%s/actions/workflows", repo), q),
httpmock.StringResponse(fmt.Sprintf(getWorkflowRunsResponse, event)))

// TODO: is this correct? is it the correct response?
reg.Register(
httpmock.REST("GET", fmt.Sprintf("repos/%s/actions/workflows/456", repo)),
httpmock.StringResponse(getWorkflowResponse))
Expand Down Expand Up @@ -147,12 +145,10 @@ JOBS
q.Set("per_page", "100")
q.Set("page", "1")

// TODO: is this correct? is it the correct response?
reg.Register(
httpmock.QueryMatcher("GET", fmt.Sprintf("repos/%s/actions/workflows", repo), q),
httpmock.StringResponse(fmt.Sprintf(getWorkflowRunsResponse, event)))

// TODO: is this correct? is it the correct response?
reg.Register(
httpmock.REST("GET", fmt.Sprintf("repos/%s/actions/workflows/456", repo)),
httpmock.StringResponse(getWorkflowResponse))
Expand Down

0 comments on commit 9847dba

Please sign in to comment.