Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render the run header in output #21

Merged
merged 27 commits into from
Nov 17, 2022
Merged

render the run header in output #21

merged 27 commits into from
Nov 17, 2022

Conversation

mdb
Copy link
Owner

@mdb mdb commented Nov 15, 2022 •
edited
Loading

Addresses issue #19 and issue #9, while also providing some cleanup.

Note that it is impacted by cli/cli#6626.

It also layers in some additional improvements...

  • dynamically determine GitHub host
  • leverage upstream functions rather than copy/pasta-re-implement them within gh-dispatch
  • improve workflow run identification (issue Improve accuracy of workflow run rendering #9 ) by matching on login actor and event

mdb added 27 commits November 15, 2022 14:56
@mdb
render the run header in output
948ae3c 
This is an attempt to address issue #19.
@mdb
attempt to use upstream packages
376cd41
@mdb
repository uses upstream CLI function to get run ID
6f9e7bc
@mdb
bump minor version
3c14d8d
@mdb
workflow uses upstream CLI function to get run ID
7c90f23
@mdb
getRunID uses upstream CLI func
803a38a
@mdb
repository uses upstream CLI GetRun func
ae53d55
@mdb
workflow uses upstream CLI GetRun func
0daf67c
@mdb
use cli GH API client in helper funcs
09980e2
@mdb
only use CLI GH client
dfb1aa3
@mdb
remove authToken from dispatchOptions
657bc4b 
This will need to be re-evaluated.
@mdb
HTTP client now configurable
efb18f1
@mdb
properly authenticate to GH API
3be7291
@mdb
use upstream func for fetching Annotations
e502ee4
@mdb
use ghRepo type in func arguments
edcb95f 
This cleans things up a bit.
@mdb
add code comments
b9f9a3b
@mdb
make test output more readable
7931ab9
@mdb
render header, similar to 'gh run watch'
3785e41
@mdb
add helpful code comments
0be3899
@mdb
match on event when finding run ID
4ccd079
@mdb
only fetch 50 workflow runs, for efficiency's sake
f331a23
@mdb
use more upstream helper funcs/utilities
446219b 
* dynamically determin GitHub host
* use GetRunsWithFilter
@mdb
match run on login actor
6c5a559
@mdb
use upstream shared.GetJobs function
58afbad
@mdb
update demo gif
bc0387c
@mdb
add README notes about acceptance tests
067fca1
@mdb
remove TODO comments
9847dba
@mdb mdb marked this pull request as ready for review November 17, 2022 14:07
@mdb mdb merged commit b493ec1 into main Nov 17, 2022
@mdb mdb deleted the render-header branch November 17, 2022 14:23
@mdb mdb mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdb