Release 0.12.3 (Ride-The-Lightning#1012)

LND Palemoon UX extension panel bug
Cookie file not generated for BTCPayServer Ride-The-Lightning#990
ECL Missing fee calculation on Dashboard Ride-The-Lightning#975
CLT channel filter on alias bug fix Ride-The-Lightning#982
CLightning to Code Lightning Ride-The-Lightning#997
Added Infographics for Channel Rebalance
CLN Base fee zero bug fix Ride-The-Lightning#987
ECL Query Route bug fix Ride-The-Lightning#1007
LND faster initial load
LND Transactions Lookup Ride-The-Lightning#1002
LND Bug fix for Routing Fee Calculation

.github/ISSUE_TEMPLATE/bug_report.md

@@ -22,7 +22,7 @@ If applicable, add screenshots to help explain your problem.
 
 **Your environment**
 * Version of `RTL`
-* Version of `lnd`
+* Version of `lnd`/`core lightning`/`eclair`
 * Version of `btcd`, `bitcoind`, or other backend
 * Browser & browser version
 * Operating system (`uname -a` on *Nix)

.github/README.md

@@ -4,7 +4,7 @@
 <a href="https://snyk.io/test/github/Ride-The-Lightning/RTL"><img src="https://snyk.io/test/github/Ride-The-Lightning/RTL/badge.svg" alt="Known Vulnerabilities" data-canonical-src="https://snyk.io/test/github/Ride-The-Lightning/RTL" style="max-width:100%;"></a>
 [![license](https://img.shields.io/github/license/DAVFoundation/captain-n3m0.svg?style=flat-square)](https://github.com/DAVFoundation/captain-n3m0/blob/master/LICENSE)
 
-**Intro** -- [Application Features](./docs/Application_features.md) -- [Road Map](./docs/Roadmap.md) -- [Application Configurations](./docs/Application_configurations.md) -- [C-Lightning](./docs/C-Lightning-setup.md) -- [Eclair](./docs/Eclair-setup.md) -- [Contribution](./docs/Contributing.md)
+**Intro** -- [Application Features](./docs/Application_features.md) -- [Road Map](./docs/Roadmap.md) -- [Application Configurations](./docs/Application_configurations.md) -- [Core Lightning](./docs/Core_lightning_setup.md) -- [Eclair](./docs/Eclair_setup.md) -- [Contribution](./docs/Contributing.md)
 
 * [Introduction](#intro)
 * [Architecture](#arch)
@@ -17,10 +17,10 @@
 
 ### <a name="intro"></a>Introduction
 RTL is a full function, device agnostic, web user interface to help manage lightning node operations.
-RTL is available on [LND](https://github.com/lightningnetwork/lnd), [C-Lightning](https://github.com/ElementsProject/lightning) and [Eclair](https://github.com/ACINQ/eclair) implementations.
+RTL is available on [LND](https://github.com/lightningnetwork/lnd), [CoreLightning](https://github.com/ElementsProject/lightning) and [Eclair](https://github.com/ACINQ/eclair) implementations.
 
-* C-Lightning users, refer to [this](./docs/C-Lightning-setup.md) page for install instructions.
-* Eclair users, refer to [this](./docs/Eclair-setup.md) page for install instructions.
+* Core Lightning users, refer to [this](./docs/Core_lightning_setup.md) page for install instructions.
+* Eclair users, refer to [this](./docs/Eclair_setup.md) page for install instructions.
 * LND users, follow the instructions below
 
 Pre-requisite for running RTL is a functioning and synced LND node. If you are a Raspberry Pi or a Linux user, you can follow the famous Stadicus's [guide](https://stadicus.github.io/RaspiBolt/) to setup a Bitcoin + Lighting node.
@@ -67,7 +67,7 @@ $ npm install --only=prod
 ### <a name="prep"></a>Prep for Execution
 RTL requires its own config file `RTL-Config.json`, to start the server and provide user authentication on the app.
 
-*Advanced users can refer to [this page](./docs/Multi-Node-setup.md), for config settings required to manage multiple nodes*
+*Advanced users can refer to [this page](./docs/Multi_node_setup.md), for config settings required to manage multiple nodes*
 
 * Copy the file `Sample-RTL-Config.json` from `./RTL/docs` to `./RTL` and rename it to `RTL-Config.json`.
 * Locate the complete path of the readable macroon file (admin.macroon) on your node and the lnd.conf file.

.github/docs/Application_configurations.md

@@ -18,12 +18,12 @@ parameters have `default` values for initial setup and can be updated after RTL
     {
       "index": <Incremental node indices starting from 1, Required>,
       "lnNode": "<Node name to uniquely identify the node in the UI, Default 'Node 1', Required>",
-      "lnImplementation": "<LNP implementation, Allowed values LND/CLT/ECL. Default 'LND', Required>",
+      "lnImplementation": "<LNP implementation, Allowed values LND/CLN/ECL. Default 'LND', Required>",
       "Authentication": {
-        "macaroonPath": "<Path for the folder containing 'admin.macaroon' (LND)/'access.macaroon' (CLT) file, Required for LND & CLT>",
+        "macaroonPath": "<Path for the folder containing 'admin.macaroon' (LND)/'access.macaroon' (CLN) file, Required for LND & CLN>",
         "swapMacaroonPath": "<Path for the folder containing 'loop.macaroon' (LND), Required for LND Loop>",
         "boltzMacaroonPath": "<Path for the folder containing 'admin.macaroon' (Boltz), Required for Boltz Swaps>",
-        "configPath": "<Full path of the lnd.conf/c-lightning config/eclair.conf file including the file name, if present locally, Optional, only mandatory for ECL if the lnApiPassword is missing>",
+        "configPath": "<Full path of the lnd.conf/core lightning config/eclair.conf file including the file name, if present locally, Optional, only mandatory for ECL if the lnApiPassword is missing>",
         "lnApiPassword": "<Password to be used for ECL API authentication. Mandatory only for ECL if the configPath is missing>"
       },
       "Settings": {
@@ -35,7 +35,7 @@ parameters have `default` values for initial setup and can be updated after RTL
         "logLevel": <logging levels, will log in accordance with the logLevel value provided, Allowed values ERROR, WARN, INFO, DEBUG>,
         "fiatConversion": <parameter to turn fiat conversion off/on. Allowed values - true, false, default false, Required>,
         "currencyUnit": "<Optional: Fiat current Unit for currency conversion, default 'USD' If fiatConversion is true, Required if fiatConversion is true>",
-        "lnServerUrl": "<Service url for LND/CLightning REST APIs for the node, e.g. https://192.168.0.1:8080 OR https://192.168.0.1:3001 OR http://192.168.0.1:8080. Default 'https://localhost:8080', Required",
+        "lnServerUrl": "<Service url for LND/Core Lightning REST APIs for the node, e.g. https://192.168.0.1:8080 OR https://192.168.0.1:3001 OR http://192.168.0.1:8080. Default 'https://localhost:8080', Required",
         "swapServerUrl": "<Service url for swap server REST APIs for the node, e.g. https://localhost:8081, Optional>",
         "boltzServerUrl": "<Service url for boltz server REST APIs for the node, e.g. https://localhost:9003, Optional>"
       }
@@ -51,12 +51,12 @@ If the environment variables are set, it will take precedence over the parameter
 PORT (port number for the rtl node server, default 3000, Required)<br />
 HOST (host for the rtl node server, default localhost, Optional)<br />
 APP_PASSWORD (Plaintext password to be provided by the parent container, NOT suggested for standalone RTL applications, to be used by Umbrel) (Optional)<br />
-LN_IMPLEMENTATION (LND/CLT/ECL. Default 'LND', Required)<br />
+LN_IMPLEMENTATION (LND/CLN/ECL. Default 'LND', Required)<br />
 LN_SERVER_URL (LN server URL for LNP REST APIs, default https://localhost:8080) (Required)<br />
 SWAP_SERVER_URL (Swap server URL for REST APIs, default http://localhost:8081) (Optional)<br />
 BOLTZ_SERVER_URL (Boltz server URL for REST APIs, default http://localhost:9003) (Optional)<br />
-CONFIG_PATH (Full path of the LNP .conf file including the file name) (Optional for LND & CLT, Mandatory for ECL if LN_API_PASSWORD is undefined)<br />
-MACAROON_PATH (Path for the folder containing 'admin.macaroon' (LND)/'access.macaroon' (CLT) file, Required for LND & CLT)<br />
+CONFIG_PATH (Full path of the LNP .conf file including the file name) (Optional for LND & CLN, Mandatory for ECL if LN_API_PASSWORD is undefined)<br />
+MACAROON_PATH (Path for the folder containing 'admin.macaroon' (LND)/'access.macaroon' (CLN) file, Required for LND & CLN)<br />
 SWAP_MACAROON_PATH (Path for the folder containing Loop's 'loop.macaroon', optional)<br />
 BOLTZ_MACAROON_PATH (Path for the folder containing Boltz's 'admin.macaroon', optional)<br />
 RTL_SSO (1 - single sign on via an external cookie, 0 - stand alone RTL authentication, Required)<br />
@@ -65,5 +65,5 @@ LOGOUT_REDIRECT_LINK (URL to re-direct to after logout/timeout from RTL, Require
 RTL_CONFIG_PATH (Path for the folder containing 'RTL-Config.json' file, Required)<br />
 BITCOIND_CONFIG_PATH (Full path of the bitcoind.conf file including the file name, Optional)<br />
 CHANNEL_BACKUP_PATH (Folder location for saving the channel backup files, valid for LND implementation only, Required if ln implementation=LND else Optional)<br />
-ENABLE_OFFERS (Boolean flag to enable the offers feature on Clighning, default false, optional)<br />
+ENABLE_OFFERS (Boolean flag to enable the offers feature on core lighning, default false, optional)<br />
 LN_API_PASSWORD (Password for Eclair implementation if the eclair.conf path is not available, Required if ln implementation=ECL && config path is undefined)<br />

.github/docs/CLTCommandCoverage.md → .github/docs/CLN_command_coverage.md

@@ -1,4 +1,4 @@
-### C-Lightning Commands Covered on RTL
+### Core Lightning Commands Covered on RTL
 
 === bitcoin ===
 - [x] feerates

.github/docs/Contributing.md

@@ -12,7 +12,7 @@ There are multiple ways you can contribute towards the development and not all o
 
 #### <a name="bug"></a>Bug Report
 Bug reports are reports of technical or functional issues with the software. Bug reports help with the removal of defects from the software and improve its quality. Guidelines for submitting a bug report:
-* Label the bug with the correct Lightning implementation (LND/C-Lightning/Eclair).
+* Label the bug with the correct Lightning implementation (LND/Core Lightning/Eclair).
 * Add the `Bug` label to the issue
 * Provide details of your configuration like Device, Operating system, Bitcoin version, Lightning implementation version, RTL version etc.
 * Attempt to explain the scenario in detail, so that the developer can try to replicate the issue at their end.
@@ -22,7 +22,7 @@ Bug reports are reports of technical or functional issues with the software. Bug
 
 #### <a name="feature"></a>Feature Request
 Feature Requests are requests raised to add new features to the application. The features requests can range from technical to functional, making the application better for everyone. Guidelines to follow for create a feature request:
-* Label the feature request with the correct Lightning implementation (LND/C-Lightning/Eclair).
+* Label the feature request with the correct Lightning implementation (LND/Core Lightning/Eclair).
 * Add the `Enhancement Request` label to the issue
 * If the feature relates to an existing aspect of the application, indicate clearly which part of the application the feature request relates to. E.g. Transactions page under Lightning menu.
 * Provide the justification for the feature request. E.g. Privacy/Security/Usability benefit.
@@ -51,21 +51,21 @@ Contributions via code is the most sought after contribution and something we en
 * To run RTL node server in development mode, open another command window, go to workspace/RTL and excute `npm run server`. This will run the script named `server` defined in package.json. This script sets the node environment as development and starts the server from rtl.js. Nodemon restarts the node application when file changes in the directory are detected.
 * This `server` script has been written for windows machine. Please update the script to set the `NODE_ENV=development` according to your machine's OS.
 * To check all available scripts for the project, explore the `scripts` section of package.json. 
-![](./screenshots/node-server-dev.jpg)
+![](../screenshots/node-server-dev.jpg)
 
 ##### Angular Frontend Server for Development
 * The last step starts the node server but it cannot detect and update the code written in Angular. We run the angular development server separately while working on the frontend of the project and package the final build once the development is finished. 
 * To run the angular development server, go to workspace/RTL and run `npm run start`. It will start the angular server at default '4200' port and serve the application on localhost:4200.
-![](./screenshots/angular-server-dev.jpg)
-![](./screenshots/localhost-ui-dev.jpg)
+![](../screenshots/angular-server-dev.jpg)
+![](../screenshots/localhost-ui-dev.jpg)
 
 ##### Package Angular Build
 * Run `npm run test` script to verify and fix, if needed, automated test cases.
 * Execute `npm run lint` to lint the code before final compilation.
 * To compile the backend code, `npm run buildbackend` script should be used. It will compile the code written in typescript in `server` folder and create a folder named `backend` with final compiled javascript code.
 * The Angular application code needs to be compiled into the output directory named `frontend` at workspace/RTL. It can be done by running `npm run buildfrontend` command in the RTL root.
 * Please make sure to remove all linting and other errors thrown by the build command before moving to the next step.
-![](./screenshots/angular-build.jpg)
+![](../screenshots/angular-build.jpg)
 
 ##### Create a Pull Request
 * Create a new branch on the github to push your updated code.

.github/docs/C-Lightning-setup.md → .github/docs/Core_lightning_setup.md

@@ -1,6 +1,6 @@
-![](./screenshots/RTL-CLT-Dashboard.png)
+![](../screenshots/RTL-CLN-Dashboard.png)
 
-## RTL C-lightning setup
+## RTL Core lightning setup
 
 * [Introduction](#intro)
 * [Pre-requisite](#prereq)
@@ -10,18 +10,18 @@
 * [Start the server and access the app](#start)
 
 ### <a name="intro"></a>Introduction
-RTL is now enabled to manage lightning nodes running C-Lightning.
+RTL is now enabled to manage lightning nodes running Core Lightning.
 
-Follow the below steps to install and setup RTL to run on C-Lightning.
+Follow the below steps to install and setup RTL to run on Core Lightning.
 
 ### <a name="prereq"></a>Pre-requisites:
-1. Functioning C-Lightning node. Follow install instructions on their [github](https://github.com/ElementsProject/lightning)
+1. Functioning Core Lightning node. Follow install instructions on their [github](https://github.com/ElementsProject/lightning)
 2. NodeJS - Can be downloaded [here](https://nodejs.org/en/download)
 3. Cl-REST - Ensure that `cl-rest` API server is installed and running. Install instructions [here](https://github.com/Ride-The-Lightning/c-lightning-REST)
 4. Copy the `access.macaroon` file from `cl-rest` to the device, on which RTL will be installed
 
 ### <a name="arch"></a>Architecture
-![](./screenshots/RTL-CLT-Arch-2.png)
+![](../screenshots/RTL-CLN-Arch-2.png)
 
 ### <a name="install"></a>Installation:
 To download a specific RTL version follow the instructions on the [release page](https://github.com/Ride-The-Lightning/RTL/releases)
@@ -50,11 +50,11 @@ RTL requires its own config file `RTL-Config.json`, to start the server and prov
 * Modify the RTL conf file per the example file below
 
 Ensure that the follow values are correct per your config:
-* `lnImplementation` - This should be `CLT`, indicating that RTL is connecting to a c-lightning node.
+* `lnImplementation` - This should be `CLN`, indicating that RTL is connecting to a core lightning node.
 * `macaroonPath` - Path of the folder containing `access.macaroon` file from cl-rest server.
 * `lnServerUrl` - complete url with ip address and port of the cl-rest server.
 * `multiPass` - Specify the password (in plain text) to access RTL. This password will be hashed and not stored as plain text.
-* `configPath` (optional) - File path of the c-lightning config file, if RTL server is local to the c-lightning server.
+* `configPath` (optional) - File path of the core lightning config file, if RTL server is local to the core lightning server.
 
 ```
 {
@@ -67,11 +67,11 @@ Ensure that the follow values are correct per your config:
   "nodes": [
     {
       "index": 1,
-      "lnNode": "c-lightning Testnet # 1",
-      "lnImplementation": "CLT",
+      "lnNode": "Core Lightning Testnet # 1",
+      "lnImplementation": "CLN",
       "Authentication": {
         "macaroonPath": "<Modify to include the path of the folder with access.macaroon>",
-        "configPath": "<Optional - Config file path for c-lightning>"
+        "configPath": "<Optional - Config file path for core lightning>"
       },
       "Settings": {
         "userPersona": "OPERATOR",

.github/docs/Eclair-setup.md → .github/docs/Eclair_setup.md

@@ -1,4 +1,4 @@
-![](./screenshots/RTL-ECL-Dashboard.png)
+![](../screenshots/RTL-ECL-Dashboard.png)
 
 ## RTL Eclair setup
 

.github/docs/Multi-Node-setup.md → .github/docs/Multi_node_setup.md

@@ -25,7 +25,7 @@ This step is only required to configure the nodes, which will be remotely connec
 7. `macaroonPath` should be set to the local path of the folder containing `admin.macaroon` file for each node. Each node must have a different folder for the `admin.macaroon` on the RTL server.
 8. `swapMacaroonPath` should be set to the local path of the folder containing `loop.macaroon` file for loop.
 9. `boltzMacaroonPath` should be set to the local path of the folder containing `admin.macaroon` file for boltz swaps.
-10. `lnServerUrl` must be set to the service url for LND/C Lightining REST APIs for each node, with the unique ip address of the node hosting lnd/clightning e.g. https://192.168.0.1:8080 OR https://192.168.0.1:3001. In this case the ip address of the node hosting lnd/clightning is '192.168.0.1'
+10. `lnServerUrl` must be set to the service url for LND/Core Lightining REST APIs for each node, with the unique ip address of the node hosting LND/Core Lightning e.g. https://192.168.0.1:8080 OR https://192.168.0.1:3001. In this case the ip address of the node hosting LND/Core Lightning is '192.168.0.1'
 11. `swapServerUrl` must be set to the swap service url. e.g. https://localhost:8081.
 12. `boltzServerUrl` must be set to the boltz service url. e.g. https://localhost:9003.
 13. `configPath` and `bitcoindConfigPath` are optional parameters which can be set only if the RTL is running locally on the same node. Else it can be set to "" or removed from the conf file all together.

.github/docs/Roadmap.md

@@ -16,7 +16,7 @@ As the functional complexity increases, we need to add automated testing to ensu
 Active node monitoring may be required to ensure reliability of routing nodes. Monitoring can include generating alerts for out-of-balance channels, inactive channels, disconnected peers, low activity channels etc. This feature will be required for professional node operaters running commercial routing nodes with a need to react to signals, requiring specific action to be taken.
 
 ### Advanced Multi-node Management
-RTL currently allows managing multiple nodes (LND or C-Lightning), via single UI. More sophistication can be built on multi-node management, with advanced top level dashboards, which summarize node level summary in a single dashboard. This feature may be required for professional node operators, who are running commercial routing nodes.
+RTL currently allows managing multiple nodes (LND or Core Lightning or Eclair), via single UI. More sophistication can be built on multi-node management, with advanced top level dashboards, which summarize node level summary in a single dashboard. This feature may be required for professional node operators, who are running commercial routing nodes.
 
 ### RTL installer
 Automate RTL setup so that installation process is simpler than the current method of following the steps provided in the Readme file. This should also help with configuration of nginx and letsencrypt, to enable access via https. Contribution on this is more than welcome.