forked from rt2zz/redux-persist
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update Type Definitions and API Docs to Make Sure They Match #5
Open
mdemichele
wants to merge
10
commits into
master
Choose a base branch
from
chore/improve-typing-for-persist-config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8dd54ba
update api docs to reflect correct PersistConfig type
mdemichele f36b17d
add missing deserialize property to PersistConfig interface
mdemichele 15d094d
add package-lock.json
mdemichele 4502dc9
remove types folder from gitignore - not sure if this is correct to do
mdemichele 0d53bac
adding types back to gitignore till I understand it more fully
mdemichele 441a9b7
remove types folder from project since this is autogenerated from the…
mdemichele 826b64d
add types folder back to gitignore - changed my mind. I think this sh…
mdemichele af77a5c
puts gitignore back to original
mdemichele 3e7bf86
keys in the MigrationManifest should be strings according to the type…
mdemichele 862ef7c
update Persistor type docs
mdemichele File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to a string type to match what's in the types.ts file, but I'm wondering, is number correct here? If you look at the migrations.md example, the keys are numbers. So, is the types.ts file wrong or is the
api.md
andmigrations.md
files wrong?