Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Request() constructor init.duplex parameter #25488

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+76 −1
Draft

Add Request() constructor init.duplex parameter #25488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
baf0435
Add `Request()` constructor `init.duplex` parameter
skyclouds2001 Dec 22, 2024
295c995
add nodejs data
skyclouds2001 Dec 29, 2024
498eb75
fix version
skyclouds2001 Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 55 additions & 1 deletion api/Request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,64 @@
}
}
},
"init_duplex_parameter": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to add the same subfeature on api.fetch?!

"__compat": {
"description": "`init.duplex` parameter",
"spec_url": "https://fetch.spec.whatwg.org/#dom-requestinit-duplex",
"support": {
"chrome": {
"version_added": "105"
},
"chrome_android": {
"version_added": false
},
"deno": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": false,
"impl_url": "https://bugzil.la/1792434"
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"nodejs": [
{
"version_added": "19.1.0"
},
{
"version_added": "18.13.0",
"version_removed": "19.0.0"
},
{
"version_added": "16.19.0",
"version_removed": "17.0.0"
}
Comment on lines +252 to +256
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can ignore <18.0.0, because the fetch API was behind a flag?

Suggested change
},
{
"version_added": "16.19.0",
"version_removed": "17.0.0"
}
}

],
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false,
"impl_url": "https://webkit.org/b/245671"
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": true,
"standard_track": true,
"deprecated": false
}
}
},
"init_keepalive_parameter": {
"__compat": {
"description": "`init.keepalive` parameter",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Request/keepalive",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM.

"spec_url": "https://fetch.spec.whatwg.org/#dom-requestinit-keepalive",
"tags": [
"web-features:fetch-keepalive"
Expand Down
21 changes: 21 additions & 0 deletions browsers/nodejs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,13 @@
"engine": "V8",
"engine_version": "9.4"
},
"16.19.0": {
"release_date": "2022-12-13",
"release_notes": "https://nodejs.org/en/blog/release/v16.19.0/",
"status": "retired",
"engine": "V8",
"engine_version": "9.4"
},
Comment on lines +408 to +414
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"16.19.0": {
"release_date": "2022-12-13",
"release_notes": "https://nodejs.org/en/blog/release/v16.19.0/",
"status": "retired",
"engine": "V8",
"engine_version": "9.4"
},

"17.0.0": {
"release_date": "2021-10-19",
"release_notes": "https://nodejs.org/en/blog/release/v17.0.0/",
Expand Down Expand Up @@ -524,13 +531,27 @@
"engine": "V8",
"engine_version": "10.7"
},
"19.1.0": {
"release_date": "2022-11-14",
"release_notes": "https://nodejs.org/en/blog/release/v19.1.0/",
"status": "retired",
"engine": "V8",
"engine_version": "10.7"
},
"19.2.0": {
"release_date": "2022-11-29",
"release_notes": "https://nodejs.org/en/blog/release/v19.2.0/",
"status": "retired",
"engine": "V8",
"engine_version": "10.7"
},
"19.3.0": {
"release_date": "2022-12-14",
"release_notes": "https://nodejs.org/en/blog/release/v19.3.0/",
"status": "retired",
"engine": "V8",
"engine_version": "10.7"
},
"19.5.0": {
"release_date": "2023-01-24",
"release_notes": "https://nodejs.org/en/blog/release/v19.5.0/",
Expand Down
Loading