-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebXR Hit Test reference docs - pt 1 #8042
Conversation
Preview URLs
FlawsNote! 1 document with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2021-08-19 10:31:58.336392) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. This is clean of typos. I have a few suggestions for wording.
- : An object containing configuration options, specifically: | ||
- `space`: The {{domxref("XRSpace")}} that will be tracked by the hit test source. | ||
- `entityTypes`: {{optional_inline}} An {{jsxref("Array")}} specifying the types of entities that should be used for the purposes of hit test source creation. If no no entity type is specified, the array defaults to a single element with the `plane` type. Possible types: | ||
- `point`: Compute hit test results based on characteristic points detected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are characteristic points?
The subtext of this question is, if I were a developer who didin't know what this is, would this provide me with enough information find out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, yeah, I think this is rather vague and "characteristic points" is what the spec says. Not sure what else to say, though. I believe plane detection and detection using meshes are known concepts to XR/3D developers. For points, this issue argues that point detection could be subsumed into mesh detection: immersive-web/hit-test#66
I'm not expert enough to clarify "points" further. Does it refer to some new detection technique? LIDAR points? Something else? I guess this could be very device-specific also, so maybe that's why the spec left it as such?
Also, the whole entityTypes
thing is rather unstable still. See immersive-web/hit-test#67 where some people also recognized that this API is rather hard to grok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least I've removed entityTypes
from the code example now (it is optional anyway).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've requested a definition. I'm fine with resolving this for now.
files/en-us/web/api/xrsession/requesthittestsourcefortransientinput/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/xrsession/requesthittestsourcefortransientinput/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/xrsession/requesthittestsourcefortransientinput/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/xrsession/requesthittestsourcefortransientinput/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joe Medley <[email protected]>
Thanks for your detailed reviews! \o/ |
6e0f39f
to
0db485d
Compare
This talks about Hit testing initialization and adds reference pages for
XRSession.requestHitTestSource()
andXRSession.requestHitTestSourceForTransientInput()
.Spec: https://immersive-web.github.io/hit-test