-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(csp): allow images from prod (developer.mozilla.org) #12514
Conversation
Otherwise we cannot load `apple-touch-icon` and `favicon` on other pages, including localhost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Otherwise we cannot load
apple-touch-icon
andfavicon
on other pages, including localhost.Summary
Problem
When running
yarn start
, and opening http://localhost:5042/en-US/ in the browser, two CSP errors appear in the console:Solution
Add
developer.mozilla.org
to the CSPimg-src
directive.How did you test this change?
Ran
yarn start
on this branch, and no CSP errors appeared in the console when openingn http://localhost:5042/en-US/.