Refactor physical properties calculations #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed magnetisation behaviour to return M_parallel (that is the moment parallel to the field direction) rather than the mean square of the Ma, Mb, Mc components This behaviour is in accord with that of Mantid/FOCUS for cf1ion but different from the default in ic1ion in McPhase (which returns M^2, Ma, Mb, Mc, M_parallel in the ic1ion.mag file).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
magnetisationandsusceptibilitycalculations from being withinic1ion::to a separate classphysprop::which is inherited by bothic1ion::andcf1ion::.magnetisationfrom outputting the root-mean-square of Mx/My/Mz to outputting M_parallel (the component of the induced moment parallel to the applied field), in agreement with the behaviour of FOCUS/Mantid.heatcapacitycalculation.ic1ionwithzeta=1e9to compare withcf1ionresults.