Collected other pull request and Fixbug memory leaks and weakness argument pointer for tcp/ip callback function #173

TienHuyIoT · 2023-11-02T11:57:08Z

Fixbug memory leaks

AysncClient recv callback handle missing call pbuf_free()

Fix crash tcp/ip api calls

Due to tcp_api_call_t msg declared local variant and used to as a pointer argument for the callback function. So this does not make sure that the memory holding the parameters of the pointer variant is handled right.

https://github.com/me-no-dev/AsyncTCP/pull/144/files

https://github.com/me-no-dev/AsyncTCP/pull/120/files

https://github.com/me-no-dev/AsyncTCP/pull/89/files

Enable setting port

- Due to tcp_api_call_t msg declared local variant and used to as a pointer argument for the callback function. So this does not make sure that the memory holding the parameters of the pointer variant is handled right.

- AysncClient recv callback handle missing call pbuf_free()

mathieucarbou · 2023-11-02T12:04:10Z

This project seems quite dead since 4y... I would rather send PRs against this one now: https://github.com/esphome/AsyncTCP which is maintained by ESPHome (https://esphome.io)

TienHuyIoT · 2023-11-02T12:15:05Z

This project seems quite dead since 4y... I would rather send PRs against this one now: https://github.com/esphome/AsyncTCP which is maintained by ESPHome (https://esphome.io)

Thanks,
You can reference my pull request. It has some fix-bug relevant to memory leaks and handling weakness tcp/ip callback function.
I checked your repository. It still has these bug in your repo.

mathieucarbou · 2023-11-02T12:22:53Z

This project seems quite dead since 4y... I would rather send PRs against this one now: https://github.com/esphome/AsyncTCP which is maintained by ESPHome (https://esphome.io)

Thanks, You can reference my pull request. It has some fix-bug relevant to memory leaks and handling weakness tcp/ip callback function. I checked your repository. It still has these bug in your repo.

This is not my repo ;-)
I am just watching and saw your PR, that's it.

If you leave it there, it will be lost. Nobody will act on it.
If you send it against a repo maintained by an organisation like ESPHome, more likely somebody will look at it and merge it.

But I have no relationship with any of these projects ;-)
Like said, I was just noticed about your PR through email and I think it has a lot of value so I took time to comment and advise you to instead send it against a maintained repo, not a dead one ;-)

TienHuyIoT · 2023-11-02T12:24:41Z

This project seems quite dead since 4y... I would rather send PRs against this one now: https://github.com/esphome/AsyncTCP which is maintained by ESPHome (https://esphome.io)

Thanks, You can reference my pull request. It has some fix-bug relevant to memory leaks and handling weakness tcp/ip callback function. I checked your repository. It still has these bug in your repo.

This is not my repo ;-) I am just watching and saw your PR, that's it.

If you leave it there, it will be lost. Nobody will act on it. If you send it against a repo maintained by an organisation like ESPHome, more likely somebody will look at it and merge it.

But I have no relationship with any of these projects ;-) Like said, I was just noticed about your PR through email and I think it has a lot of value so I took time to comment and advise you to instead send it against a maintained repo, not a dead one ;-)

I got it,
Thank you!

- Running async tcp by default core - Disable watchdog handler async tcp task - _tcp_recved() should be called when it has processed the data

mathieucarbou · 2024-04-26T23:40:31Z

src/AsyncTCP.cpp

@@ -417,7 +422,7 @@ static esp_err_t _tcp_write(tcp_pcb * pcb, int8_t closed_slot, const char* data,
 static err_t _tcp_recved_api(struct tcpip_api_call_data *api_call_msg){
    tcp_api_call_t * msg = (tcp_api_call_t *)api_call_msg;
    msg->err = ERR_CONN;
-    if(msg->closed_slot == -1 || !_closed_slots[msg->closed_slot]) {
+    if(msg->closed_slot != -1 || !_closed_slots[msg->closed_slot]) {


this condition does not make any sense anymore: is it tested ? If msg->closed_slot == -1, second expression is evaluated with an index being -1. If not -1, second expression is not evaluated.

@TienHuyIoT : ^^ ?

closed_slot is int8_t so -1 means 255, but _closed_slots is an array of 16.

mathieucarbou · 2024-04-27T10:34:02Z

I've grabbed most of the fixes in my fork: mathieucarbou/AsyncTCP#10

Still, please see my comment. A change in one condition looks really weird to me.

- Increase queue to 128

- Priority: 3 - Queue size: 128

mathieucarbou · 2024-07-17T12:13:40Z

src/AsyncTCP.cpp

+    while (connected() && !send()) {
+        taskYIELD();
+    }


@TienHuyIoT: when using SSE events in ESPAsycnWebServer, I think this busy loop can wait forever in case of a WIFi disconnection because the client is still seen there and connected

mathieucarbou · 2024-10-13T09:36:24Z

src/AsyncTCP.cpp

        }
+        pbuf_free(b);


The pbuf_free change is OK but the remaining changes no.
See here for more details: tbnobody/OpenDTU#2326 (comment)

This causes a drastic slowdown of the readings.

TienHuyIoT and others added 10 commits January 13, 2021 14:51

[esp32_async_tcp] Allow change tcp port

66c82d6

Applied me-no-dev#144

74420db

https://github.com/me-no-dev/AsyncTCP/pull/144/files

Added keepalive

83f855b

https://github.com/me-no-dev/AsyncTCP/pull/120/files

Added keepalive

6125471

https://github.com/me-no-dev/AsyncTCP/pull/120/files

Allow setting queue and stack size via user defines

f8faa06

https://github.com/me-no-dev/AsyncTCP/pull/89/files

Allow setting queue and stack size via user defines

1b85959

https://github.com/me-no-dev/AsyncTCP/pull/89/files

Allow setting queue and stack size via user defines

9298a07

https://github.com/me-no-dev/AsyncTCP/pull/89/files

Merge remote-tracking branch 'origin/feature/update_tcp_port'

552d17c

Enable setting port

Fix crash tcp/ip api calls

de1ddda

- Due to tcp_api_call_t msg declared local variant and used to as a pointer argument for the callback function. So this does not make sure that the memory holding the parameters of the pointer variant is handled right.

Fixbug memory leaks

9af997f

- AysncClient recv callback handle missing call pbuf_free()

TienHuyIoT force-pushed the master branch 2 times, most recently from ee0155f to fd6447f Compare November 4, 2023 03:30

Imrovement

5bbad55

- Running async tcp by default core - Disable watchdog handler async tcp task - _tcp_recved() should be called when it has processed the data

TienHuyIoT force-pushed the master branch from fd6447f to 5bbad55 Compare December 16, 2023 14:47

Enable WDT to avoid suspended

4589401

mathieucarbou reviewed Apr 26, 2024

View reviewed changes

mathieucarbou added a commit to mathieucarbou/AsyncTCP that referenced this pull request Apr 27, 2024

Grab fixes from me-no-dev/AsyncTCP#173

a3cbcdb

mathieucarbou added a commit to mathieucarbou/AsyncTCP that referenced this pull request Apr 27, 2024

Grab fixes from me-no-dev/AsyncTCP#173

4870385

mathieucarbou added a commit to mathieucarbou/AsyncTCP that referenced this pull request Apr 27, 2024

Grab fixes from me-no-dev/AsyncTCP#173

65b4e99

mathieucarbou mentioned this pull request Apr 27, 2024

Grab fixes from https://github.com/me-no-dev/AsyncTCP/pull/173 mathieucarbou/AsyncTCP#10

Merged

mathieucarbou mentioned this pull request May 29, 2024

Arduino 3 / ESP IDF 5 compatibility esphome/AsyncTCP#11

Closed

Configure

f7d543b

- Increase queue to 128

TienHuyIoT and others added 3 commits June 12, 2024 22:08

changed

5c8789a

- Priority: 3 - Queue size: 128

Merge branch 'me-no-dev:master' into master

eba332d

Merge branch 'master' of https://github.com/TienHuyIoT/AsyncTCP

1256267

mathieucarbou reviewed Jul 17, 2024

View reviewed changes

mathieucarbou mentioned this pull request Jul 17, 2024

[BUG] mathieucarbou/ESPAsyncWebServer#57

Closed

Merge https://github.com/me-no-dev/AsyncTCP

2b5ed28

mathieucarbou reviewed Oct 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Collected other pull request and Fixbug memory leaks and weakness argument pointer for tcp/ip callback function #173

Collected other pull request and Fixbug memory leaks and weakness argument pointer for tcp/ip callback function #173

TienHuyIoT commented Nov 2, 2023

mathieucarbou commented Nov 2, 2023

TienHuyIoT commented Nov 2, 2023

mathieucarbou commented Nov 2, 2023 •

edited

Loading

TienHuyIoT commented Nov 2, 2023 •

edited

Loading

mathieucarbou Apr 26, 2024 •

edited

Loading

mathieucarbou Jul 4, 2024

mathieucarbou Jul 4, 2024

mathieucarbou commented Apr 27, 2024

mathieucarbou Jul 17, 2024

mathieucarbou Oct 13, 2024

Collected other pull request and Fixbug memory leaks and weakness argument pointer for tcp/ip callback function #173

Are you sure you want to change the base?

Collected other pull request and Fixbug memory leaks and weakness argument pointer for tcp/ip callback function #173

Conversation

TienHuyIoT commented Nov 2, 2023

mathieucarbou commented Nov 2, 2023

TienHuyIoT commented Nov 2, 2023

mathieucarbou commented Nov 2, 2023 • edited Loading

TienHuyIoT commented Nov 2, 2023 • edited Loading

mathieucarbou Apr 26, 2024 • edited Loading

Choose a reason for hiding this comment

mathieucarbou Jul 4, 2024

Choose a reason for hiding this comment

mathieucarbou Jul 4, 2024

Choose a reason for hiding this comment

mathieucarbou commented Apr 27, 2024

mathieucarbou Jul 17, 2024

Choose a reason for hiding this comment

mathieucarbou Oct 13, 2024

Choose a reason for hiding this comment

mathieucarbou commented Nov 2, 2023 •

edited

Loading

TienHuyIoT commented Nov 2, 2023 •

edited

Loading

mathieucarbou Apr 26, 2024 •

edited

Loading