fix: recipe scaling #4324
Merged
fix: recipe scaling #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
approved these changes
Oct 7, 2024
michael-genson
merged commit 56bd68d
into
mealie-recipes:mealie-next
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This update changes the scale value of the recipe scaler to be rounded to 32 digits instead of 3. This addresses an issue where scaling a larger number up or down by one (e.g. 24 -> 23) would result in a rounded number (e.g. 22.992 instead of 23) rather than the correct value. Since the scale is based on 1 and the servings are calculated by multiplying the scale by the number of servings, more precise rounding is required. The value 32 is chosen to match the precision used in the backend for numbers requiring greater accuracy.
Which issue(s) this PR fixes:
None