Small feature to introduce step prop for number fields #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@shannonhochkins is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
chrisvxd
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Looks great! Thanks @shannonhochkins!
Just has some conflicts, and needs formatting (npm run format + commit).
…tep-attribute-for-number-fields
Of course there was a change to the same files I was working on since i pushed :D - Fixed and ran format |
chrisvxd
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a very small change to add a
stepattribute for number field types.Usage - I have a field for opacity, it's value should be between 0-1, the default step value for number fields is 1, so I can't use my keyboard / arrow buttons on the field to increment a smaller amount without typing the value myself.
This is a low level feature change - unsure if i've missed anything else in the repo that needs to be updated!