centralize url unique hash generation with helper method in this package #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulbot
requested review from
pgulley,
kilemensi,
philbudne and
thepsalmist
pgulley
approved these changes
Dec 13, 2023
philbudne
approved these changes
Dec 13, 2023
thepsalmist
approved these changes
Dec 13, 2023
kilemensi
approved these changes
Dec 13, 2023
|
(prob should have rebased instead of pulling in main, but 🤷🏽♂️) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various places across our repos need to generate the unique hash for a URL. This adds a small
unique_url_hashhelper method and a new property (same name) returned from calls toextract. Based on idea proposed in mediacloud/story-indexer#194 (comment), mostly because it only took about 5 minutes and made sense to me. Very open to counter-arguments about whether this is the right place.