Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused upstream files #180

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Remove unused upstream files #180

merged 1 commit into from
Aug 29, 2023

Conversation

elsiehupp
Copy link
Member

I've created a new repository for these files, in case we ever feel like doing anything with them.

@elsiehupp elsiehupp enabled auto-merge (squash) August 29, 2023 12:59
@elsiehupp elsiehupp force-pushed the remove-unused-upstream branch 2 times, most recently from a880e8d to 465515c Compare August 29, 2023 13:27
@randomnetcat
Copy link
Collaborator

Is there a reason to delete launcher and uploader? Those should be working, and at least I am using them.

@elsiehupp
Copy link
Member Author

Is there a reason to delete launcher and uploader? Those should be working, and at least I am using them.

If you're using them, they can stay! I didn't actually know what all was still in use, so I can put them back!

@elsiehupp
Copy link
Member Author

@randomnetcat does it look good now?

I'm pretty sure the three files I just put back were the only ones that actually referred back to mediawiki-scraper. So the other files don't actually need to be in sync with the main package.

@elsiehupp elsiehupp merged commit b48a138 into python3 Aug 29, 2023
4 checks passed
@elsiehupp elsiehupp deleted the remove-unused-upstream branch August 29, 2023 17:57
@robkam
Copy link
Member

robkam commented Aug 29, 2023

The other files are mostly lists of wikis and no longer up-to-date. Live lists like these should be fetched by a script as required, e.g. from WikiApiary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants