-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#9598): add training materials page #9592
Conversation
…ing-page # Conflicts: # tests/e2e/default/enketo/training-cards.wdio-spec.js
@Benmuiruri @kapelo I've finished the unit and e2e test coverage. Can you please review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The 3 suggestions are all optional and not a blocker.
tests/e2e/default/training-materials/training-materials.wdio-spec.js
Outdated
Show resolved
Hide resolved
tests/e2e/default/training-materials/training-materials.wdio-spec.js
Outdated
Show resolved
Hide resolved
Test: Loads other Enketo widgets and saves training in the reports list page.We dont expect people to use input fields in trainings because trainings are more informative (text, images), but still good that they work fine. Screen.Recording.2024-11-14.at.6.55.39.PM.mp4Test: Training materials page shouldn't list expired trainings. Also, it should refresh the list when new trainings are configured by the system admin and the start date is nowScreen.Recording.2024-11-14.at.7.10.38.PM.mp4Test: Show confirmation message when leaving trainingScreen.Recording.2024-11-14.at.7.16.47.PM.mp4Test: Works fine in the old navScreen.Recording.2024-11-14.at.7.30.12.PM.mp4 |
…ing-page # Conflicts: # tests/page-objects/default/common/common.wdio.page.js
@kapelo I have uploaded testing videos, do you have any feedback? |
One more test. And that's all Test: Refresh list to show indicator of recently completed trainingScreen.Recording.2024-11-14.at.10.25.28.PM.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added 2 comments that should be quick to address
Description
Training cards in modal
Training materials page
Training materials page and training cards in modal
Overall functionality - happy path
Screen.Recording.2024-11-11.at.5.41.44.PM.mp4
Pagination on list
Screen.Recording.2024-11-11.at.5.47.14.PM.mp4
#9598
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.