Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove instrumentation on check connection #141

Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore: remove instrumentation on check connection #141

merged 1 commit into from
Nov 7, 2024

Conversation

GuillaumeDecMeetsMore
Copy link
Collaborator

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore commented Nov 6, 2024 •
edited
Loading

Changed

  • This function is used by the healthcheck route, which is often called
    • Filling APM storage with this route is not really useful, nor is it useful to know what is happening inside this route (as it does nothing)

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore self-assigned this Nov 6, 2024
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore marked this pull request as ready for review November 7, 2024 01:42
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore merged commit 038304f into master Nov 7, 2024
2 checks passed
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore deleted the guillaume/chore/do-not-instrument-check-connection branch November 7, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm-derek mm-derek mm-derek approved these changes

@mm-zacharydavison mm-zacharydavison Awaiting requested review from mm-zacharydavison

Assignees

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeDecMeetsMore @mm-derek