Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-ISSUE] feat/handle graceful shutdown for k8s #154

Merged

Conversation

GuillaumeDecMeetsMore
Copy link
Collaborator

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore commented Dec 2, 2024

  • Add graceful shutdown logic, adapted for k8s
  • Add 2 new environment variables
    • NITTEI__SERVER_SHUTDOWN_SLEEP: time in seconds that the app "sleeps/waits" before really shutting down
      • During that sleep time, a flag is already updated making the "status" endpoint to respond that the app is not ready anymore
    • NITTEI__SERVER_SHUTDOWN_TIMEOUT: time in seconds that the app waits for all HTTP handlers to finish

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore self-assigned this Dec 2, 2024
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore marked this pull request as ready for review December 2, 2024 06:32
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore merged commit 4d8d008 into master Dec 2, 2024
2 checks passed
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore deleted the guillaume/feat/handle-graceful-shutdown-for-k8s branch December 2, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants