Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO-ISSUE] feat(users): allow to provide external userId (uuid) #17

Merged
merged 16 commits into from
Jul 25, 2024
Merged

[NO-ISSUE] feat(users): allow to provide external userId (uuid) #17

merged 16 commits into from
Jul 25, 2024

Conversation

GuillaumeDecMeetsMore
Copy link
Collaborator

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore commented Jul 18, 2024 •
edited
Loading

Changed

  • Added possibility of providing the user's UUID (PK) when creating a user

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore self-assigned this Jul 18, 2024
GuillaumeDecMeetsMore
GuillaumeDecMeetsMore commented Jul 18, 2024
View reviewed changes
scheduler/clients/javascript/lib/userClient.ts
@@ -20,6 +20,7 @@ type UpdateUserRequest = {

type CreateUserRequest = {
metadata?: Metadata;
userId?: string;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add JSDocs to all client lib's exposed functions/types in another PR

GuillaumeDecMeetsMore
GuillaumeDecMeetsMore commented Jul 18, 2024
View reviewed changes
scheduler/crates/api/src/user/create_user.rs Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main change (1)

GuillaumeDecMeetsMore
GuillaumeDecMeetsMore commented Jul 18, 2024
View reviewed changes
scheduler/crates/api_structs/src/user/api.rs Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main change (2)

GuillaumeDecMeetsMore
GuillaumeDecMeetsMore commented Jul 18, 2024
View reviewed changes
scheduler/crates/domain/src/user.rs Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main change (3)

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore mentioned this pull request Jul 18, 2024
Merged
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore force-pushed the guillaume/feat/user-allow-to-provide-external-user-uuid branch from 1c2cf11 to a08d635 Compare July 22, 2024 04:35
Base automatically changed from guillaume/test/add-integration-test-for-our-use-cases to master July 25, 2024 00:50
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore dismissed mm-zacharydavison’s stale review July 25, 2024 00:50

The base branch was changed.

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore enabled auto-merge (squash) July 25, 2024 08:31
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore merged commit 6951dcb into master Jul 25, 2024
2 checks passed
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore deleted the guillaume/feat/user-allow-to-provide-external-user-uuid branch July 25, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm-zacharydavison mm-zacharydavison mm-zacharydavison approved these changes

Assignees

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeDecMeetsMore @mm-zacharydavison