Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO-ISSUE] refactor: use axios instead of custom implem for query #21

Merged
merged 21 commits into from
Jul 25, 2024
Merged

[NO-ISSUE] refactor: use axios instead of custom implem for query #21

merged 21 commits into from
Jul 25, 2024

Conversation

GuillaumeDecMeetsMore
Copy link
Collaborator

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore commented Jul 24, 2024 •
edited
Loading

Changed

  • Adapted TS code so that the lib uses Axios' features as much as possible (custom instance + let Axios handle the encoding of query params)

GuillaumeDecMeetsMore and others added 17 commits July 11, 2024 11:32
@GuillaumeDecMeetsMore
refactor: adapt/update js client
805f4e2
@GuillaumeDecMeetsMore
chore: update justfile
941e65f
@GuillaumeDecMeetsMore
ci: adapt JS client lib's CI
d2234a7
@GuillaumeDecMeetsMore
test: start adding integration tests for our use cases
446f130
@GuillaumeDecMeetsMore
ci: fix actions/setup-node usage for pnpm
0a4f16c
@GuillaumeDecMeetsMore
ci: update actions + install pnpm
1f0bd04
@GuillaumeDecMeetsMore
ci: remove cache on actions/setup-node as it's pretty fast
b1df0f7
@GuillaumeDecMeetsMore
Merge branch 'guillaume/ci/adapt-js-client-ci' into guillaume/test/ad…
cee3d0f 
…d-integration-test-for-our-use-cases
@GuillaumeDecMeetsMore
Merge branch 'master' into guillaume/test/add-integration-test-for-ou…
a08ea16 
…r-use-cases
@GuillaumeDecMeetsMore
test: add more tests to integration tests
8bac479
@GuillaumeDecMeetsMore
Merge branch 'master' into guillaume/test/add-integration-test-for-ou…
10439cb 
…r-use-cases
@GuillaumeDecMeetsMore
refactor: rename file + adapt requirements' tests
6800201
@GuillaumeDecMeetsMore
feat(users): allow to provide external userId (uuid)
e556c34
@GuillaumeDecMeetsMore
chore: fix formatting
a08d635
@GuillaumeDecMeetsMore
test(requirements): provide userUuid
4626cf1
@GuillaumeDecMeetsMore
feat(js lib): add format + lint biome + fixes
6d1bf21
@GuillaumeDecMeetsMore
refactor: use axios instead of custom implem for query
7e587cd
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore self-assigned this Jul 24, 2024
Base automatically changed from guillaume/feat/add-format-lint-via-biome to master July 25, 2024 09:14
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore merged commit d32c21d into master Jul 25, 2024
2 checks passed
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore deleted the guillaume/refactor/use-axios-instead-of-custom-implem branch July 25, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm-zacharydavison mm-zacharydavison mm-zacharydavison approved these changes

Assignees

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeDecMeetsMore @mm-zacharydavison