feat: allow to query on multiple calendars of same user #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-integration-test-for-our-use-cases
…' into guillaume/feat/add-format-lint-via-biome
…e/refactor/convert-unix-timestamps-to-datetimes
…low query metadata
…' into guillaume/feat/add-js-docs-client-lib
…eat/allow-to-query-free-busy-multiple
Base automatically changed from
guillaume/feat/allow-to-query-free-busy-multiple
to
master
August 19, 2024 09:06
Comment on lines
-379
to
-381
| describe('A user can be in groups', () => { | ||
| it.todo('To be implemented') | ||
| }) |
There was a problem hiding this comment.
Not handled by calendar service
mm-zacharydavison
approved these changes
Aug 27, 2024
| @@ -111,6 +111,35 @@ pub mod get_event { | |||
| pub type APIResponse = CalendarEventResponse; | |||
| } | |||
|
|
|||
| pub mod get_events_by_calendars { | |||
There was a problem hiding this comment.
A general question:
How do you plan to document the Rust code?
I don't know what the conventions are.
There was a problem hiding this comment.
Good question!
I admit ideally I should add comments (conventions)
I'll keep that in mind of the following PRs
GuillaumeDecMeetsMore
deleted the
guillaume/feat/allow-to-query-multiple-calendars
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed