Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO-ISSUE] fix: allow to bind other host with env var #38

Merged
merged 2 commits into from
Aug 30, 2024
Merged

[NO-ISSUE] fix: allow to bind other host with env var #38

merged 2 commits into from
Aug 30, 2024

Conversation

GuillaumeDecMeetsMore
Copy link
Collaborator

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore commented Aug 30, 2024 •
edited
Loading

Changed

  • Allow to specify host address to be bound via env var (127.0.0.1 is default, but we want 0.0.0.0 when deployed)
    • NITTEI_HOST
  • Rename env var PORT to NITTEI_PORT

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore self-assigned this Aug 30, 2024
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore marked this pull request as ready for review August 30, 2024 06:02
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore enabled auto-merge (squash) August 30, 2024 06:04
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore merged commit 1d61bd0 into master Aug 30, 2024
2 checks passed
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore deleted the guillaume/fix/allow-to-bind-other-host-by-env-var branch August 30, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianweiliu tianweiliu tianweiliu approved these changes

@mm-zacharydavison mm-zacharydavison Awaiting requested review from mm-zacharydavison

Assignees

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeDecMeetsMore @tianweiliu