Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/add datadog tracing exporter #44

Merged

Conversation

GuillaumeDecMeetsMore
Copy link
Collaborator

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore commented Sep 2, 2024

Changed

  • Add (unofficial) Datadog trace exporter
  • Add simple logger middleware for request
  • Add #[derive(debug)] on repositories' structs
    • This is required (for printing the "state" of the repository inside the span)
  • Add #[instrument] on all repositories' methods
    • This simply wraps the processing inside a span (APM)
  • Adapt Tracing configuration so that
    • It uses Datadog exporter if DATADOG_TRACING_ENDPOINT env var is defined
    • It uses OpenTelemetry HTTP exporter if OTLP_TRACING_ENDPOINT env var is defined
  • Adapt logger so that it prints JSON (but not Bunyan format anymore)

Todo (later - in other PRs)

  • Add log processing pipeline in DD
  • Adapt as much as possible logs' format to match DD expected format (without making it too complex)

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore self-assigned this Sep 2, 2024
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore marked this pull request as ready for review September 3, 2024 06:39
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore merged commit 0f0fab5 into master Sep 4, 2024
2 checks passed
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore deleted the guillaume/fix/add-datadog-tracing-exporter branch September 4, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants