feat(js client): improve things (one axios client, keepAlive, baseUrl… #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-zacharydavison
requested changes
Sep 3, 2024
| constructor(nettuAccount: string, token?: string) { | ||
| this.nettuAccount = nettuAccount | ||
| this.token = token | ||
| export const createAxiosInstanceFrontend = ( |
There was a problem hiding this comment.
Can you document? What's the difference between this and createAxiosInstanceBackend?
There was a problem hiding this comment.
Updated 👍
The main difference is that one allow keepAlive, which needs the function to be async as it needs to import a Node package.
Technically, it could be only one function, but I think it makes it easier for the frontend to still have a function that isn't async. That way, it can be defined directly as a variable in a file (export ....) on the frontend
| /** | ||
| * Nettu account id (admin) | ||
| */ | ||
| nettuAccount?: string |
There was a problem hiding this comment.
For the moment nettu is still used everywhere
I think I'll just make one big PR renaming everything to nittei
mm-zacharydavison
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
baseUrlcan be provided in the parameter of the function creating a new ClientkeepAliveconnections