refactor/improve error handling

justfile

@@ -5,6 +5,7 @@ export RUST_BACKTRACE := "1"
 install_tools: 
 	cargo install sqlx-cli
 	cargo install cargo-pretty-test
+	cargo install cargo-watch
 
 # Install all tools
 install_all_tools: install_tools
@@ -26,7 +27,7 @@ _setup_client_node:
 
 # Dev
 dev: _setup_db
-	cd scheduler && cargo run
+	cd scheduler && cargo watch -- cargo run
 
 # Prepare offline SQLx
 prepare_sqlx:

scheduler/Cargo.toml

@@ -22,6 +22,8 @@ nettu_scheduler_api = { path = "./crates/api" }
 nettu_scheduler_domain = { path = "./crates/domain" }
 nettu_scheduler_infra = { path = "./crates/infra" }
 
+anyhow = "1.0"
+
 actix-web = "4.8"
 
 tokio = { version = "1", features = ["full"] }
@@ -57,9 +59,13 @@ nettu_scheduler_sdk = { path = "./clients/rust" }
 unsafe_code = "forbid"
 
 [lints.clippy]
-print_stdout = "forbid"
-print_err = "forbid"
+print_stdout = "deny"
+print_err = "deny"
+unwrap_used = "deny"
+expect_used = "deny"
 
 [workspace.lints.clippy]
-print_stdout = "forbid"
-print_err = "forbid"
+print_stdout = "deny"
+print_err = "deny"
+unwrap_used = "deny"
+expect_used = "deny"

scheduler/clippy.toml

@@ -0,0 +1,2 @@
+allow-unwrap-in-tests = true
+allow-expect-in-tests = true

scheduler/crates/api/Cargo.toml

@@ -22,7 +22,7 @@ async-trait = "0.1.42"
 rrule = "0.12.0"
 chrono = { version = "0.4.19", features = ["serde"] }
 chrono-tz = "0.8.1"
-anyhow = "1.0.0"
+anyhow = "1.0"
 jsonwebtoken = "7"
 thiserror = "1.0"
 tracing = "0.1.25"

scheduler/crates/api/src/account/set_account_webhook.rs

@@ -90,7 +90,7 @@ mod tests {
     #[actix_web::main]
     #[test]
     async fn it_rejects_invalid_webhook_url() {
-        let ctx = setup_context().await;
+        let ctx = setup_context().await.unwrap();
         let bad_uris = vec!["1", "", "test.zzcom", "test.com", "google.com"];
         for bad_uri in bad_uris {
             let mut use_case = SetAccountWebhookUseCase {
@@ -114,7 +114,7 @@ mod tests {
     #[actix_web::main]
     #[test]
     async fn it_accepts_valid_webhook_url() {
-        let ctx = setup_context().await;
+        let ctx = setup_context().await.unwrap();
 
         let valid_uris = vec!["https://google.com", "https://google.com/v1/webhook"];
         for valid_uri in valid_uris {

scheduler/crates/api/src/calendar/create_calendar.rs

@@ -68,13 +68,15 @@ struct CreateCalendarUseCase {
 
 #[derive(Debug)]
 enum UseCaseError {
+    InternalError,
     UserNotFound,
     StorageError,
 }
 
 impl From<UseCaseError> for NettuError {
     fn from(e: UseCaseError) -> Self {
         match e {
+            UseCaseError::InternalError => Self::InternalError,
             UseCaseError::StorageError => Self::InternalError,
             UseCaseError::UserNotFound => {
                 Self::NotFound("The requested user was not found.".to_string())
@@ -92,7 +94,14 @@ impl UseCase for CreateCalendarUseCase {
     const NAME: &'static str = "CreateCalendar";
 
     async fn execute(&mut self, ctx: &NettuContext) -> Result<Self::Response, Self::Error> {
-        let user = match ctx.repos.users.find(&self.user_id).await {
+        let user = ctx
+            .repos
+            .users
+            .find(&self.user_id)
+            .await
+            .map_err(|_| UseCaseError::InternalError)?;
+
+        let user = match user {
             Some(user) if user.account_id == self.account_id => user,
             _ => return Err(UseCaseError::UserNotFound),
         };

scheduler/crates/api/src/calendar/delete_calendar.rs

@@ -50,13 +50,15 @@ pub async fn delete_calendar_controller(
 
 #[derive(Debug)]
 pub enum UseCaseError {
+    InternalError,
     NotFound(ID),
     UnableToDelete,
 }
 
 impl From<UseCaseError> for NettuError {
     fn from(e: UseCaseError) -> Self {
         match e {
+            UseCaseError::InternalError => Self::InternalError,
             UseCaseError::NotFound(calendar_id) => Self::NotFound(format!(
                 "The calendar with id: {}, was not found.",
                 calendar_id
@@ -81,7 +83,12 @@ impl UseCase for DeleteCalendarUseCase {
     const NAME: &'static str = "DeleteCalendar";
 
     async fn execute(&mut self, ctx: &NettuContext) -> Result<Self::Response, Self::Error> {
-        let calendar = ctx.repos.calendars.find(&self.calendar_id).await;
+        let calendar = ctx
+            .repos
+            .calendars
+            .find(&self.calendar_id)
+            .await
+            .map_err(|_| UseCaseError::InternalError)?;
         match calendar {
             Some(calendar) if calendar.user_id == self.user_id => ctx
                 .repos