Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local tests #495

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix local tests #495

merged 1 commit into from
Jan 8, 2025

Conversation

talonchandler
Copy link
Collaborator

Fixes #494.

Keeps temporary data in tmp_path, which gets deleted.

@talonchandler talonchandler marked this pull request as ready for review January 8, 2025 00:23
@talonchandler talonchandler requested a review from ziw-liu January 8, 2025 01:36
@ziw-liu ziw-liu added bug Something isn't working testing Testing the code labels Jan 8, 2025
Copy link
Contributor

@ziw-liu ziw-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@talonchandler talonchandler added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 6b34489 Jan 8, 2025
7 checks passed
@ziw-liu ziw-liu deleted the repeatable-local-tests branch January 8, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Testing the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Local tests fail when run repeatedly
2 participants