Support batches API #1062
Open
Support batches API #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellnix
force-pushed
the
batches-methods-1050
branch
from
daf6e60 to
cbb59ca
Compare
ellnix
commented
Jan 17, 2025
| @@ -113,3 +113,46 @@ def __init__(self, resp: Dict[str, Any]) -> None: | |||
| self.total: int = resp["total"] | |||
| self.from_: int = resp["from"] | |||
| self.next_: int = resp["next"] | |||
|
|
|||
|
|
|||
| class Batch(CamelBase): | |||
There was a problem hiding this comment.
I kept this class mostly the same as the Task model, including (some) of the validations.
I used Optional[*] instead of the Union[*, None] which was widely used in Task.
|
|
||
| class Batch(CamelBase): | ||
| uid: int | ||
| details: Optional[Dict[str, Any]] = None |
There was a problem hiding this comment.
Let me know if any of this is legacy syntax, I tried to maintain the same style as Task as much as possible.
There was a problem hiding this comment.
Even though in the previous PR I would have just done:
details: Dict[str, Any]Additionally, I'm assuming Dict is fine here (instead of Mapping) since we know that we get Dicts as responses from web requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #1050