Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support batches API #1062

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Support batches API #1062

merged 3 commits into from
Jan 23, 2025

Conversation

ellnix
Copy link
Contributor

@ellnix ellnix commented Jan 17, 2025

Pull Request

Related issue

Fixes #1050

@ellnix ellnix force-pushed the batches-methods-1050 branch from daf6e60 to cbb59ca Compare January 17, 2025 14:11
ellnix
ellnix commented Jan 17, 2025
View reviewed changes
Copy link
Contributor Author

@ellnix ellnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Batches are made of tasks, so it made sense to me for them to be handled by the TaskHandler, and be tested side by side with tasks.

As always, let me know if I did something stupid 😄

meilisearch/models/task.py Show resolved Hide resolved
meilisearch/models/task.py Show resolved Hide resolved
@ellnix ellnix changed the title Batches methods 1050 Support batches API Jan 17, 2025
@curquiza curquiza requested a review from sanders41 January 22, 2025 13:22
@curquiza
Copy link
Member

@sanders41 I put you as reviewer everywhere, but feel free to say you don't have the time of course 😁

sanders41
sanders41 requested changes Jan 23, 2025
View reviewed changes
meilisearch/models/task.py Show resolved Hide resolved
meilisearch/task.py Outdated Show resolved Hide resolved
meilisearch/models/task.py Outdated Show resolved Hide resolved
meilisearch/task.py Outdated Show resolved Hide resolved
meilisearch/task.py Show resolved Hide resolved
tests/client/test_client_task_meilisearch.py Outdated Show resolved Hide resolved
@ellnix ellnix force-pushed the batches-methods-1050 branch from cbb59ca to cdbebe4 Compare January 23, 2025 17:15
@ellnix ellnix force-pushed the batches-methods-1050 branch from cdbebe4 to a7051c7 Compare January 23, 2025 17:17
@ellnix
Copy link
Contributor Author

ellnix commented Jan 23, 2025

I applied your suggestions, and rebased to remove the conflict on code-samples.

Should I try to update legacy code based on your suggestions, or should I leave it be?

@ellnix ellnix requested a review from sanders41 January 23, 2025 17:23
sanders41
sanders41 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 23, 2025

Build succeeded:

@ellnix ellnix closed this Jan 23, 2025
@meili-bors meili-bors bot merged commit 6941a59 into meilisearch:main Jan 23, 2025
11 checks passed
@sanders41 sanders41 added the enhancement New feature or request label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanders41 sanders41 sanders41 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.12.0] Add methods for the batches API
3 participants
@ellnix @curquiza @sanders41