Remove in the next version non-exitant experimental feature #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
commented
Jan 24, 2025
| @@ -29,7 +29,7 @@ pub fn generate_tenant_token( | |||
| return Err(Error::InvalidUuid4Version); | |||
| } | |||
|
|
|||
| if expires_at.map_or(false, |expires_at| OffsetDateTime::now_utc() > expires_at) { | |||
| if expires_at.is_some_and(|expires_at| OffsetDateTime::now_utc() > expires_at) { | |||
irevoire
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Perfecto, thanks for the contribution @CommanderStorm 👍
bors merge
|
Build succeeded: |
meili-bors
bot
merged commit 926749f
into
meilisearch:bump-meilisearch-v1.13
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
related to #637
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!