Don't return 0 when attempting to read from the GPA GPIO addresses with GPIO disabled #2266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently melon would return
0
if something is attempted to be read from the addresses 0x080000C4-0x080000C8, but gba roms can and do have data in that place, while games using custom gpio hardware have those bytes set to 0 since they're mapped to the gpio lines.Now it will instead consider those addresses as special only if the game explicitly attempted to enable gpio by writing to the control address.
Fixes #2264