-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(taps): Make stream logger a child of the tap logger #1854
feat(taps): Make stream logger a child of the tap logger #1854
Conversation
Example logs:
Note the This works together really nice with custom logging: version: 1
disable_existing_loggers: false
loggers:
singer_sdk.metrics:
level: ERROR
sample-tap-countries.continents:
level: WARNING
sample-tap-countries.countries:
level: DEBUG Results in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1854 +/- ##
=======================================
Coverage 86.83% 86.83%
=======================================
Files 58 58
Lines 4885 4885
Branches 777 777
=======================================
Hits 4242 4242
Misses 456 456
Partials 187 187 ☔ View full report in Codecov by Sentry. |
7e33b31
to
de69d50
Compare
CodSpeed Performance ReportMerging #1854 will not alter performanceComparing Summary
|
<tap name>
in logging config logger will continue work as expected.Closes #333
📚 Documentation preview 📚: https://meltano-sdk--1854.org.readthedocs.build/en/1854/