Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(targets): Handle missing record properties in SQL sinks #1865

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 20, 2023

Closes #1134

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1865 (b336e17) into main (019902e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1865      +/-   ##
==========================================
+ Coverage   86.71%   86.72%   +0.01%     
==========================================
  Files          59       59              
  Lines        5014     5018       +4     
  Branches      813      814       +1     
==========================================
+ Hits         4348     4352       +4     
  Misses        470      470              
  Partials      196      196              
Files Changed Coverage Δ
singer_sdk/testing/suites.py 100.00% <ø> (ø)
singer_sdk/sinks/sql.py 90.35% <100.00%> (+0.17%) ⬆️
singer_sdk/testing/target_tests.py 94.54% <100.00%> (+0.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…utomatically-tranformed-into-null-values-during-insertmerge
…utomatically-tranformed-into-null-values-during-insertmerge
…utomatically-tranformed-into-null-values-during-insertmerge
…utomatically-tranformed-into-null-values-during-insertmerge
@edgarrmondragon edgarrmondragon force-pushed the 1134-bugsql-targets-missing-fields-are-not-automatically-tranformed-into-null-values-during-insertmerge branch from 451f3a7 to b336e17 Compare July 26, 2023 19:48
@edgarrmondragon edgarrmondragon merged commit 6576f52 into main Jul 26, 2023
25 checks passed
@edgarrmondragon edgarrmondragon deleted the 1134-bugsql-targets-missing-fields-are-not-automatically-tranformed-into-null-values-during-insertmerge branch July 26, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(sql-targets): missing fields are not automatically tranformed into null values during insert/merge
2 participants