Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support other content-types in REST streams #2762

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 13, 2024

@edgarrmondragon edgarrmondragon requested review from a team as code owners November 13, 2024 05:37
@edgarrmondragon edgarrmondragon linked an issue Nov 13, 2024 that may be closed by this pull request
@edgarrmondragon edgarrmondragon marked this pull request as draft November 13, 2024 05:37
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #2762 will not alter performance

Comparing 2761-feat-support-other-content-types-for-http-streams (9065247) with main (72c9a19)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (72c9a19) to head (9065247).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2762      +/-   ##
==========================================
+ Coverage   90.74%   90.80%   +0.05%     
==========================================
  Files          62       62              
  Lines        5102     5122      +20     
  Branches      659      660       +1     
==========================================
+ Hits         4630     4651      +21     
  Misses        330      330              
+ Partials      142      141       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon self-assigned this Nov 13, 2024
@edgarrmondragon edgarrmondragon added this to the v0.43 milestone Nov 13, 2024
@edgarrmondragon edgarrmondragon force-pushed the 2761-feat-support-other-content-types-for-http-streams branch from b4d7d0a to f829f74 Compare November 13, 2024 05:51
@edgarrmondragon edgarrmondragon force-pushed the 2761-feat-support-other-content-types-for-http-streams branch from f829f74 to ee6fbc9 Compare November 14, 2024 01:41
@edgarrmondragon edgarrmondragon changed the title WIP: Support other content-types for HTTP streams WIP: Support other content-types in REST streams Nov 14, 2024
@edgarrmondragon edgarrmondragon changed the title WIP: Support other content-types in REST streams feat: Support other content-types in REST streams Nov 14, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 14, 2024 01:52
@edgarrmondragon edgarrmondragon added Release Highlight Call this out in the release notes Type/Tap Singer taps labels Nov 14, 2024
@edgarrmondragon edgarrmondragon merged commit 25527c4 into main Nov 14, 2024
37 checks passed
@edgarrmondragon edgarrmondragon deleted the 2761-feat-support-other-content-types-for-http-streams branch November 14, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Release Highlight Call this out in the release notes Type/Tap Singer taps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support other content-types for HTTP streams
1 participant