Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(targets): The last received Singer message is now logged when the target fails #2765

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 14, 2024

@edgarrmondragon edgarrmondragon linked an issue Nov 14, 2024 that may be closed by this pull request
@edgarrmondragon edgarrmondragon added the Type/Target Singer targets label Nov 14, 2024
@edgarrmondragon edgarrmondragon self-assigned this Nov 14, 2024
@edgarrmondragon edgarrmondragon added this to the v0.43 milestone Nov 14, 2024
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #2765 will not alter performance

Comparing 2763-feat-log-the-last-message-received-when-the-target-fails (159298c) with main (25527c4)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.81%. Comparing base (25527c4) to head (159298c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2765      +/-   ##
==========================================
+ Coverage   90.80%   90.81%   +0.01%     
==========================================
  Files          62       62              
  Lines        5122     5130       +8     
  Branches      660      660              
==========================================
+ Hits         4651     4659       +8     
  Misses        330      330              
  Partials      141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 15, 2024 03:46
@edgarrmondragon edgarrmondragon force-pushed the 2763-feat-log-the-last-message-received-when-the-target-fails branch from 796f171 to 159298c Compare November 15, 2024 03:54
@edgarrmondragon edgarrmondragon merged commit 344a218 into main Nov 15, 2024
36 checks passed
@edgarrmondragon edgarrmondragon deleted the 2763-feat-log-the-last-message-received-when-the-target-fails branch November 15, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Target Singer targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Log the last message received when the target fails
1 participant