Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Loaders] Improve web page and sitemap loader usability #961

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Nov 16, 2023

Description

Improving web page and sitemap data loader by:

  • Adding request session for webpage loader
  • Add tqdm to sitemap loader

Type of change

  • Refactor (does not change functionality, e.g. code style improvements, linting)

@deshraj deshraj force-pushed the user/dyadav/improve-loaders branch from d0a16f6 to 6e46bdc Compare November 16, 2023 23:51
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (28460f7) 66.67% compared to head (68c5cd4) 66.67%.

Files Patch % Lines
embedchain/loaders/sitemap.py 0.00% 2 Missing ⚠️
embedchain/loaders/web_page.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   66.67%   66.67%   -0.01%     
==========================================
  Files         116      116              
  Lines        4204     4210       +6     
==========================================
+ Hits         2803     2807       +4     
- Misses       1401     1403       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit e0b73e6 into main Nov 17, 2023
3 of 5 checks passed
@deshraj deshraj deleted the user/dyadav/improve-loaders branch November 17, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant