Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve GitHub loader #962

Merged
merged 5 commits into from
Nov 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions embedchain/loaders/github.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import logging
import os

from tqdm import tqdm

Check warning on line 6 in embedchain/loaders/github.py

View check run for this annotation

Codecov / codecov/patch

embedchain/loaders/github.py#L6

Added line #L6 was not covered by tests

from embedchain.loaders.base_loader import BaseLoader
from embedchain.loaders.json import JSONLoader
from embedchain.loaders.mdx import MdxLoader
Expand Down Expand Up @@ -53,14 +55,24 @@

return data.get("data", [])

def _is_file_empty(file_path):
return os.path.getsize(file_path) == 0

Check warning on line 59 in embedchain/loaders/github.py

View check run for this annotation

Codecov / codecov/patch

embedchain/loaders/github.py#L58-L59

Added lines #L58 - L59 were not covered by tests

def _is_whitelisted(file_path):
whitelisted_extensions = ["md", "txt", "html", "json", "py", "js", "jsx", "ts", "tsx", "mdx", "rst"]
_, file_extension = os.path.splitext(file_path)
return file_extension[1:] in whitelisted_extensions

Check warning on line 64 in embedchain/loaders/github.py

View check run for this annotation

Codecov / codecov/patch

embedchain/loaders/github.py#L61-L64

Added lines #L61 - L64 were not covered by tests

def _add_repo_files(repo_path: str):
with concurrent.futures.ThreadPoolExecutor() as executor:
future_to_file = {
executor.submit(_load_file, os.path.join(root, filename)): os.path.join(root, filename)
for root, _, files in os.walk(repo_path)
for filename in files
} # noqa: E501
for future in concurrent.futures.as_completed(future_to_file):
if _is_whitelisted(os.path.join(root, filename))
and not _is_file_empty(os.path.join(root, filename)) # noqa:E501
}
for future in tqdm(concurrent.futures.as_completed(future_to_file), total=len(future_to_file)):

Check warning on line 75 in embedchain/loaders/github.py

View check run for this annotation

Codecov / codecov/patch

embedchain/loaders/github.py#L75

Added line #L75 was not covered by tests
file = future_to_file[future]
try:
results = future.result()
Expand Down
8 changes: 8 additions & 0 deletions embedchain/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,10 @@
logging.debug(f"Source of `{formatted_source}` detected as `csv`.")
return DataType.CSV

if url.path.endswith(".mdx") or url.path.endswith(".md"):
logging.debug(f"Source of `{formatted_source}` detected as `mdx`.")
return DataType.MDX

Check warning on line 221 in embedchain/utils.py

View check run for this annotation

Codecov / codecov/patch

embedchain/utils.py#L220-L221

Added lines #L220 - L221 were not covered by tests

if url.path.endswith(".docx"):
logging.debug(f"Source of `{formatted_source}` detected as `docx`.")
return DataType.DOCX
Expand Down Expand Up @@ -292,6 +296,10 @@
logging.debug(f"Source of `{formatted_source}` detected as `xml`.")
return DataType.XML

if source.endswith(".mdx") or source.endswith(".md"):
logging.debug(f"Source of `{formatted_source}` detected as `mdx`.")
return DataType.MDX

Check warning on line 301 in embedchain/utils.py

View check run for this annotation

Codecov / codecov/patch

embedchain/utils.py#L300-L301

Added lines #L300 - L301 were not covered by tests

if source.endswith(".yaml"):
with open(source, "r") as file:
yaml_content = yaml.safe_load(file)
Expand Down
Loading