Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import beautifulsoup pacakge lazily. #964

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Conversation

taranjeet
Copy link
Member

@taranjeet taranjeet commented Nov 17, 2023

Description

This commit lazily loads the bs4 import. This is needed so that not everyone has to install the bs4 package.
Without this, it throws an error and requires everyone to install the bs4 package.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

This commit lazily loads the bs4 import.
This is needed so that not everyone has to
install the bs4 package
@taranjeet taranjeet requested a review from deshraj November 17, 2023 16:33
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (023a614) 66.51% compared to head (5724c5d) 66.49%.

Files Patch % Lines
embedchain/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
- Coverage   66.51%   66.49%   -0.03%     
==========================================
  Files         116      116              
  Lines        4223     4223              
==========================================
- Hits         2809     2808       -1     
- Misses       1414     1415       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit 51df007 into main Nov 18, 2023
@deshraj deshraj deleted the taranjeet/utils-import-refactor branch November 18, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants