Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for custom streaming callback #971

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Nov 22, 2023

Description

This PR adds support for a custom streaming callback through langchain to be able to serve streaming responses in HTTP calls.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit Test

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (798d3fc) 66.46% compared to head (484a6fe) 66.03%.

Files Patch % Lines
embedchain/helpers/callbacks.py 0.00% 28 Missing ⚠️
embedchain/bots/discord.py 0.00% 1 Missing ⚠️
embedchain/bots/slack.py 0.00% 1 Missing ⚠️
embedchain/chunkers/mysql.py 0.00% 1 Missing ⚠️
embedchain/chunkers/substack.py 0.00% 1 Missing ⚠️
embedchain/chunkers/unstructured_file.py 0.00% 1 Missing ⚠️
embedchain/embedder/base.py 50.00% 1 Missing ⚠️
embedchain/loaders/sitemap.py 0.00% 1 Missing ⚠️
embedchain/loaders/substack.py 0.00% 1 Missing ⚠️
embedchain/loaders/unstructured_file.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #971      +/-   ##
==========================================
- Coverage   66.46%   66.03%   -0.43%     
==========================================
  Files         116      117       +1     
  Lines        4213     4243      +30     
==========================================
+ Hits         2800     2802       +2     
- Misses       1413     1441      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit f6b80e0 into main Nov 22, 2023
3 of 5 checks passed
@deshraj deshraj deleted the user/dyadav/add-custom-streaming-callback branch November 22, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant