Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Fix issue of missing user directory #975

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Nov 24, 2023

Description

Fixes #940

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Unit Test

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (58f72e1) 65.99% compared to head (5e8c211) 65.95%.

Files Patch % Lines
embedchain/store/assistants.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #975      +/-   ##
==========================================
- Coverage   65.99%   65.95%   -0.04%     
==========================================
  Files         117      117              
  Lines        4243     4241       -2     
==========================================
- Hits         2800     2797       -3     
- Misses       1443     1444       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit 1df46b2 into main Nov 24, 2023
4 of 5 checks passed
@deshraj deshraj deleted the user/dyadav/create-user-dir branch December 7, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sqlite
1 participant