Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ENV environment variable to docker compose file #1069

Closed
wants to merge 1 commit into from
Closed

Add ENV environment variable to docker compose file #1069

wants to merge 1 commit into from

Conversation

aanokh
Copy link

@aanokh aanokh commented Jan 16, 2025

Add ENV environment variable to the docker compose file so setting ENV=local in the .env will work properly. fixes #930

@aanokh
Copy link
Author

aanokh commented Jan 16, 2025

I think this is the more correct approach than #765

@nickscamara nickscamara requested a review from mogery January 25, 2025 22:30
mogery
mogery reviewed Feb 6, 2025
View reviewed changes
Copy link
Member

@mogery mogery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! This is also invalid, since we use ENV=production both for local development of a prod target and for staging, neither of which have HTTPS support.

@aanokh aanokh closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogery mogery mogery left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Self-Host] Max retries local error
2 participants
@aanokh @mogery